Skip to content

C++: Import AST GVN module for tests#2861

Merged
geoffw0 merged 3 commits into
github:masterfrom
MathiasVP:gvn-use-impl
Feb 19, 2020
Merged

C++: Import AST GVN module for tests#2861
geoffw0 merged 3 commits into
github:masterfrom
MathiasVP:gvn-use-impl

Conversation

@MathiasVP

Copy link
Copy Markdown
Contributor

Fixes imports of two GVN tests. The tests imported the module that change depending on whether or not the IR is enabled. This affected the output from GVN tests in #2851.

@MathiasVP MathiasVP added the C++ label Feb 18, 2020
@MathiasVP MathiasVP requested a review from a team as a code owner February 18, 2020 11:26
@jbj

jbj commented Feb 18, 2020

Copy link
Copy Markdown
Contributor

LGTM, but it'll cause a semantic merge conflict with #2851, so we can't merge this yet.

@jbj

jbj commented Feb 19, 2020

Copy link
Copy Markdown
Contributor

@MathiasVP Please merge master into this PR and update the expected files.

@geoffw0 geoffw0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants